Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix JobStatusDisplay width #1377

Closed
wants to merge 2 commits into from
Closed

Fix JobStatusDisplay width #1377

wants to merge 2 commits into from

Conversation

Flowdalic
Copy link
Member

@Flowdalic Flowdalic commented Aug 31, 2024 •
edited
Loading

Fixes #1348

@Flowdalic
JobStatusDisplay: fix setting the default width to 100
2b47b68 
This fixes a28a0fd ("JobStatusDisplay: increase the default width
to 100") which attempted to set the default width to 100. However, the
out of bounds check in _set_width() was not adjusted. Therefore, the
default width was effectively still 80.

Fixes: a28a0fd
Signed-off-by: Florian Schmaus <[email protected]>
@Flowdalic Flowdalic mentioned this pull request Aug 31, 2024
Closed
@Flowdalic
JobStatusDisplay: introduce max_display_width variable
636c59a 
Values that belong together and may only be changed at the same time
should be combined in a common constant. So let's do this.

Signed-off-by: Florian Schmaus <[email protected]>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thesamesam thesamesam thesamesam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Flowdalic @thesamesam