Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test output management command #832

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

gregorjerse
Copy link
Contributor

The command is not finished. There are some issues to resolve.

  • some connectors (S3...) store only files and not directories, so directory tests will fail.
  • just by iterating through schema it is impossible to tell if reference is a directory and what should that directory contain.
  • I could consult the database to check if the entry is a directory or not. If it is I could also obtain the list of all entries in that directory. But let stick with basic file testing for now.

@gregorjerse
Copy link
Contributor Author

We already have validate_data method on the StorageLocation object that checks the existance of every referenced path in the given storage location.

Do we still need this check? It has some benefits (checks that the outputs are really there). If yes, I suggest we simplify it and only chech that the outputs of the data objects are referenced in the database. The health of the storage locations can then be checked with the validate_data if necessary.

@gregorjerse gregorjerse requested a review from dblenkus December 16, 2024 12:23
@gregorjerse gregorjerse assigned gregorjerse and unassigned dblenkus Dec 16, 2024
@gregorjerse gregorjerse force-pushed the feature/check_output branch 3 times, most recently from 036c844 to f7bfe9c Compare December 16, 2024 13:40
@gregorjerse gregorjerse merged commit dc68c71 into genialis:master Dec 18, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants