Skip to content
This repository was archived by the owner on Oct 3, 2025. It is now read-only.

Conversation

@Danori
Copy link

@Danori Danori commented Apr 17, 2024

Resolves "is" and "is not" compiler warnings introduced in python 3.8 when comparing literals.
See https://discuss.python.org/t/demoting-the-is-operator-to-avoid-an-identity-crisis/86 for more details.

Before:
before

After:
after

Resolves "is" and "is not" compiler warnings introduced in python 3.8
when comparing literals.
See https://discuss.python.org/t/demoting-the-is-operator-to-avoid-an-identity-crisis/86
for more details.
@Danori Danori added the bug Something isn't working label Apr 17, 2024
@Danori Danori requested review from dongqiu and taylor-codes April 17, 2024 19:24
@Danori Danori self-assigned this Apr 17, 2024
Copy link

@taylor-codes taylor-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@Danori Danori changed the title fix: resolve python3 compiler warnings fix: resolve python3 syntax warnings Apr 17, 2024
@Danori Danori merged commit 377571f into generalmotors:fix/python3-compiler-warnings Apr 17, 2024
Danori pushed a commit that referenced this pull request Apr 25, 2024
@Danori Danori deleted the fix/python3-compiler-warnings branch July 25, 2024 13:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants