Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge run interfaces #61

Merged
merged 3 commits into from
Aug 22, 2023
Merged

Merge run interfaces #61

merged 3 commits into from
Aug 22, 2023

Conversation

general-CbIC
Copy link
Owner

@general-CbIC general-CbIC commented Aug 17, 2023

Improvements based on review comments from #59

Poolex.run!/3 was removed in favor of Poolex.run/3. The new unified function returns {:ok, result} or {:error, :checkout_timeout} and not handles runtime errors anymore.

  • Reason: We should not catch errors in the caller process. The caller process itself must choose how to handle exceptions and exit signals.

@general-CbIC general-CbIC changed the title #59 review fixes Get rid off run!/3 Aug 17, 2023
@general-CbIC general-CbIC marked this pull request as ready for review August 17, 2023 11:33
@general-CbIC general-CbIC changed the title Get rid off run!/3 Merge run interfaces Aug 18, 2023
@general-CbIC general-CbIC merged commit 99a53d9 into develop Aug 22, 2023
10 checks passed
@general-CbIC general-CbIC deleted the feature/review-fixes branch August 22, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant