feat: Add Opencode Plugin#21
Merged
Merged
Conversation
- Create opencode plugin for - Plugin scans on session starts - Tool evaluation on tool.execute.before - Temporarily allow tool execution via sage_approve - Permanently allow tool execution via sage_allowlist_add - Create unit, integration, and e2e tests
- insert plugin scan result at text.complete - update walkPluginFiles to also handle the case when installPath is a file
- Update instructions for install Opencode Plugin - fix linting issues
Tomáš Ďuriš (TommYDeeee)
requested changes
Feb 26, 2026
Tomáš Ďuriš (TommYDeeee)
left a comment
Tomáš Ďuriš (TommYDeeee)
left a comment
Collaborator
There was a problem hiding this comment.
Thank you for this PR, really appreciate it! I have left few notes bellow. Once it is sorted it looks good!
Regarding the:
- Added E2E tests for the plugin, but they currently cannot pass due to an unaddressed upstream OpenCode bug
Do you expect this to be resolved and addressed in other PR (or here?) once it can be? For now those tests probably can be marked to be skipped.
Contributor
Author
|
Thanks, Tomáš Ďuriš (@TommYDeeee). I’ve addressed all of the review comments. I also found a workaround for the Please let me know if you have any further comments or suggestions. |
Tomáš Ďuriš (TommYDeeee)
self-requested a review
February 27, 2026 17:42
Tomáš Ďuriš (TommYDeeee)
previously approved these changes
Feb 27, 2026
Tomáš Ďuriš (TommYDeeee)
left a comment
Tomáš Ďuriš (TommYDeeee)
left a comment
Collaborator
There was a problem hiding this comment.
LGTM! Thanks, now just the small typo (nitpick) and it can be merged.
Feiyou Guo (FeiyouG)
force-pushed
the
main
branch
from
February 27, 2026 18:22
8d4d305 to
91b0868
Compare
Contributor
Author
|
Oh right my bad. It is now fixed. |
Tomáš Ďuriš (TommYDeeee)
self-requested a review
February 28, 2026 12:40
Tomáš Ďuriš (TommYDeeee)
previously approved these changes
Feb 28, 2026
Vaclav Belak (vaclavbelak)
requested changes
Mar 2, 2026
Vaclav Belak (vaclavbelak)
left a comment
Vaclav Belak (vaclavbelak)
left a comment
Collaborator
There was a problem hiding this comment.
Thank you very much for your contribution! I have to ask you to address a few issues, two of which are major.
Major:
- fragile handling of Sage's verdict via try/catch could lead to a security hole if the message changes
sage_approveis inferior to a properaskwhich seems to be supported by OpenCode
Minor:
- closing tag in the prompt/instructions
- Fix cache dir resolution on plugin-scan - Refactor E2E test structure to parse opencode output as JSON
Vaclav Belak (vaclavbelak)
previously approved these changes
Mar 3, 2026
Vaclav Belak (vaclavbelak)
left a comment
Vaclav Belak (vaclavbelak)
left a comment
Collaborator
There was a problem hiding this comment.
LGTM - thank you
Tomáš Ďuriš (TommYDeeee)
self-requested a review
March 3, 2026 09:46
Tomáš Ďuriš (TommYDeeee)
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tool.execute.beforeandexperimental.text.complete.sage_approve,sage_allowlist_add, andsage_allowlist_remove.Tests
v1.2.14(macOS15.6.1).opencode run --commandfails withcommand3.agenton 1.2.14 anomalyco/opencode#15150