Skip to content

Add url params #1179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sonic16x merged 1 commit into from
Dec 16, 2025
Merged

Add url params #1179

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 21 additions & 18 deletions src/browser/existing-browser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,30 +340,33 @@ export class ExistingBrowser extends Browser {
}

protected _decorateUrlMethod(session: WebdriverIO.Browser): void {
session.overwriteCommand("url", async (origUrlFn, uri): Promise<void | string | WebdriverIO.Request> => {
if (!uri) {
return session.getUrl();
}
session.overwriteCommand(
"url",
async (origUrlFn, uri, params): Promise<void | string | WebdriverIO.Request> => {

@shadowusr shadowusr Dec 12, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you checked how do the typescript typings work, does typescript see params type in tests code?

@sonic16x sonic16x Dec 16, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, all works, I tested it

if (!uri) {
return session.getUrl();
}

const newUri = this._resolveUrl(uri);
this._meta.url = newUri;
const newUri = this._resolveUrl(uri);
this._meta.url = newUri;

if (this._config.urlHttpTimeout) {
this.setHttpTimeout(this._config.urlHttpTimeout);
}
if (this._config.urlHttpTimeout) {
this.setHttpTimeout(this._config.urlHttpTimeout);
}

const result = await origUrlFn(newUri);
const result = await origUrlFn(newUri, params);

if (this._config.urlHttpTimeout) {
this.restoreHttpTimeout();
}
if (this._config.urlHttpTimeout) {
this.restoreHttpTimeout();
}

if (this._clientBridge) {
await this._clientBridge.call("resetZoom");
}
if (this._clientBridge) {
await this._clientBridge.call("resetZoom");
}

return result;
});
return result;
},
);
}

protected _resolveUrl(uri: string): string {
Expand Down
Loading