Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add isInsurance endpoint #263

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Add isInsurance endpoint #263

wants to merge 1 commit into from

Conversation

Johennes
Copy link
Contributor

@Johennes Johennes commented Sep 9, 2024

Changes:

  • New endpoint /v1/domain/isInsurance
  • Changed "domain" to "server" / "serverName" (avoids misunderstandings, e.g. about subdomains)
  • Removed operationIds (seemed unused)
  • Shortened and deduplicated some of the summaries and descriptions
  • Removed default status codes from all responses (not an actual status code, response schema already inherited)
  • Pushed parameters one level down beneath get (so that we don't accidentally reuse them in future)
  • Wrapped findByIk response in object (matching isInsurance, more idiomatic and extensible)
  • Translated German descriptions in InfoObject

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant