Return json from magic code authenticate endpoint if no callback_url is given #9012
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a configuration property to the provider config that will have the sign-in flow act as a sign-up flow if set to true.
scotttrinh
approved these changes
Sep 9, 2025
| ) | ||
| response_dict = {"code": auth_code} | ||
|
|
||
| if maybe_callback_url: |
There was a problem hiding this comment.
Mostly a note for the future: I think the better approach would be to check the accept header and vary the required request body parameters based on whether the request accepts JSON or not. But what we have here matches our current defensive strategy and I wouldn't want to change this without making it a wider-reaching change across the whole auth server.
scotttrinh
force-pushed
the
magic-link-auto-sign-up
branch
from
2c48e7d to
bb135a0
Compare
aljazerzen
pushed a commit
that referenced
this pull request
Sep 11, 2025
…is given (#9012) Match the behaviour of the email+password authenticate endpoint, and return a json response if the `callback_url` is not passed to the magic code authenticate endpoint. --------- Co-authored-by: Scott Trinh <[email protected]>
aljazerzen
added
backported-7.x
and removed
to-backport-7.x
aljazerzen
pushed a commit
that referenced
this pull request
Sep 11, 2025
…is given (#9012) Match the behaviour of the email+password authenticate endpoint, and return a json response if the `callback_url` is not passed to the magic code authenticate endpoint. --------- Co-authored-by: Scott Trinh <[email protected]>
aljazerzen
pushed a commit
that referenced
this pull request
Sep 11, 2025
…is given (#9012) Match the behaviour of the email+password authenticate endpoint, and return a json response if the `callback_url` is not passed to the magic code authenticate endpoint. --------- Co-authored-by: Scott Trinh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Match the behaviour of the email+password authenticate endpoint, and return a json response if the
callback_urlis not passed to the magic code authenticate endpoint.