Fix nightly build of ls #8969
Merged
Fix nightly build of ls #8969
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Followup for #8906 This PR fixes two things, broken in 991ce4b: - when checking for SCM version, we were looking for gel-server, - we were (trying) to run tests. I've added package.basename to targets, so we can dynamically look for correct packages. I've disabled running tests. We should be running them and I see that there are some variables to support filtering test files, but I don't know what exactly is wrong when the tests report the following: ``` Error: test path '/gel/share/tests' does not exist ``` So the tests are disabled for now, I hope elvis can help.
msullivan
approved these changes
Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup for #8906
This PR fixes two things, broken in
991ce4b:
I've added package.basename to targets, so we can dynamically look for
correct packages.
I've disabled running tests. We should be running them and I see that
there are some variables to support filtering test files, but I don't
know what exactly is wrong when the tests report the following:
So the tests are disabled for now, I hope elvis can help.