Fix backwards incompatible change in ai extension #1234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scotttrinh
force-pushed
the
fix-ai-embedding-body
branch
from
b546836 to
6420289
Compare
The name of this property changed during the development of the ai extension, and in the latest verison, we dropped support for shadowing the same value across both names, so this is now an error.
scotttrinh
force-pushed
the
fix-ai-embedding-body
branch
from
6420289 to
f1724a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The name of this property changed during the development of the ai
extension, and in the latest verison, we dropped support for shadowing
the same value across both names, so this is now an error.
Also use the same error handling code from the RAG querying code.
Closes #1232