[Forwardport] Clean code#52
Merged
Merged
Conversation
…commit 9d3be73 changed the default behaviour of \Magento\Quote\Model\ResourceModel\Quote\Item\Collection::getStoreId() using the store coming from the current session instead of using the one from quote. The previous commit was made to fix an error while using getItems() without setting a quote. The current fix restore the previous behaviour and adds a check if the quote is not specified.
…s in the js-translations.json magento#16892 - Merge Pull Request magento#16892 from mage2pratik/magento2:2.3-develop-PR-port-13528 - Merged commits: 1. 18d11f5
- Merge Pull Request magento#16888 from mage2pratik/magento2:code-improvement-3 - Merged commits: 1. 95c2f75 2. d13033b
…ento#16875 - Merge Pull Request magento#16875 from mageprince/magento2:mageprince-2.3-patch-pull-13 - Merged commits: 1. eaf98d1 2. 9230424 3. 93c0bb7 4. 7d581c7
… prices for combination of options
… prices for combination of options
… prices for combination of options
… prices for combination of options
… prices for combination of options
…n with Basic Fraud Protection
recoding to pass travis coding standards
… prices for combination of options
…iew when user adding product from wishlist section.
… if options are selected for configurable product magento#8168 - adding optimization
[2.3.0-Regression] MAGETWO-90995 Error on info:language:list call
- merged latest code from mainline branch
- Merge Pull Request magento#17080 from mage2pratik/magento2:fix-double-occurrence-2 - Merged commits: 1. 6a02ff6 2. e8c3fec 3. ab96cb3
…7107 - Merge Pull Request magento#17107 from mage2pratik/magento2:code-cleanup-loginpost - Merged commits: 1. 91074c4
- Merge Pull Request magento#17106 from mage2pratik/magento2:2.3-develop-PR-port-16921 - Merged commits: 1. a993cf1 2. 3ba9464
Accepted Public Pull Requests: - magento#17056: [Forwardport] Add generated code to the psr-0 autoloader section so when optimizing� (by @torhoehn) - magento#17049: [Forwardport] Log when Magento is in maintenance mode (by @torhoehn) - magento#17044: [Forwardport] Update nginx.config.sample to exclude php5-fpm (by @torhoehn) - magento#17054: [Forwardport] Remove extra spaces from Magento/Ui (by @torhoehn) - magento#17060: [Forwardport] fix: add hasrequired notice for create account form and password forg� (by @DanielRuf) - magento#17042: [Forwardport] Remove direct use of object manager (by @torhoehn) - magento#16956: [Forwardport] Trim issue on customer confirmation form (by @gelanivishal) - magento-engcom/import-export-improvements#117: magento-engcom/import-export-improvements#103 Fail product import validation when multiselect columns contain duplicate values (by @pogster) - magento#17043: [Forwardport] Add Clean Code (by @torhoehn) - magento#17046: [Forwardport] Remove duplicated string. (by @torhoehn) Fixed GitHub Issues: - magento#6058: IE11 user login email validation fails if field has leading or trailing space (reported by @dnadle) has been fixed in magento#16956 by @gelanivishal in 2.3-develop branch Related commits: 1. f3502da 2. 9d15ecc 3. 6897f27 - magento#103: Phoenix/Moneybookers (reported by @riconeitzel) has been fixed in magento-engcom/import-export-improvements#117 by @pogster in 2.3-develop branch Related commits: 1. a765ec7 2. d45e4f8
…correct object type error magento#17055
…#17028 - Merge Pull Request magento#17028 from chirag-wagento/magento2:2.3-develop-PR-port-17019 - Merged commits: 1. 742df86
Accepted Public Pull Requests: - magento#17080: Removed double occurrences from files (by @mage2pratik) - magento#17045: [Forwardport] Fixing annotations for some methods. (by @torhoehn) - magento#17052: [Forwardport] Fix for Magnifier in inside mode (by @torhoehn) - magento#16925: [Up Port] Replacing Usage of Deprecated Methods for Message Manager. (by @tiagosampaio) - magento#17055: [Forwardport] Credit memo email template file: fixing incorrect object type error (by @torhoehn) - magento#17028: [Forwardport] Fixes Black color coding standard. (by @chirag-wagento) - magento#17106: [Forwardport] Slight Changes to Code (by @mage2pratik) - magento#17107: [Forwardport] Reduce lengthy code of LoginPost (by @mage2pratik) Fixed GitHub Issues: - magento#4977: Magnifier doesn't work with mode set to inner (reported by @theycallmepepper) has been fixed in magento#17052 by @torhoehn in 2.3-develop branch Related commits: 1. 1db38b0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original Pull Request
magento#16841
Description
Just modify some code, and make it Cleaner more...