Skip to content

[Forwardport] Create ability to set is_visible_on_front to order status history comment#45

Merged
gelanivishal merged 2 commits into2.3-developfrom
2.3-develop-PR-port-15637
Jul 7, 2018
Merged

[Forwardport] Create ability to set is_visible_on_front to order status history comment#45
gelanivishal merged 2 commits into2.3-developfrom
2.3-develop-PR-port-15637

Conversation

@gelanivishal
Copy link
Copy Markdown
Owner

Original Pull Request

magento#15637
Create ability to set is_visible_on_front to order status history comment.

Description

The parameter is_visible_on_front is able to be set from the admin, but not from addStatusHistoryComment of the order model. This would provide the ability to set this value from custom code such as event observers.

Manual testing scenarios

  1. Call ->addStatusHistoryComment($comment, false) to not set is_visible_on_front (backwards compatible with no extra param)
  2. Call ->addStatusHistoryComment($comment, false, true) to set is_visible_on_front
  3. Call ->addStatusHistoryComment($comment, false, false) to not set is_visible_on_front

Contribution checklist

  • [x ] Pull request has a meaningful description of its purpose
  • [x ] All commits are accompanied by meaningful commit messages
  • [x ] All new or changed code is covered with unit/integration tests (if applicable)
  • [x ] All automated tests passed successfully (all builds on Travis CI are green)

@gelanivishal gelanivishal merged commit 016163c into 2.3-develop Jul 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants