Skip to content

[Backport] Fix $useCache for container child blocks#37

Merged
gelanivishal merged 25 commits into2.1-developfrom
2.1-develop-PR-port-14029
Jun 30, 2018
Merged

[Backport] Fix $useCache for container child blocks#37
gelanivishal merged 25 commits into2.1-developfrom
2.1-develop-PR-port-14029

Conversation

@gelanivishal
Copy link
Copy Markdown
Owner

Original Pull Request

magento#14029

Description

This is a follow-up from PR magento#4919.

When one would use getChildHtml() like the following to output a container uncached:
<?= $block->getChildHtml('category.products.list.product_meta', false); ?>
The container's child blocks would still be cached.

Fixed Issues (if relevant)

  1. getChildHtml, $useCache and child containers magento/magento2#4919: getChildHtml, $useCache and child containers

Manual testing scenarios

  1. Add a container to block category.products.list.
  2. Add a custom template to the container and output something that should be different every time it gets rendered, like <?= rand() ?>.
  3. Output the container in Magento/Catalog/templates/products/list.phtml using getChildHtml() and set $useCache to false.
  4. The output is the same with each getChildHtml() of the container.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Vasilii Burlacu and others added 25 commits June 20, 2018 23:33
…onths` to show more than 1 month

(cherry picked from commit 54e1a71)
…mage/calendar when setting \`numberOfM… magento#16280

 - Merge Pull Request magento#16280 from vasilii-b/magento2:MAGETWO-61209-calendar-widget-number-of-months_mage21
 - Merged commits:
   1. ce38bc8
…y[] = works faster than invoking functions in PHP
…ing admin login attempts cleanup magento#16347

 - Merge Pull Request magento#16347 from rogyar/magento2:2.1-captcha-reset-admin-it
 - Merged commits:
   1. d8cab67
… ...', $array[] = works faster than invoking functions in PHP magento#16359

 - Merge Pull Request magento#16359 from lfluvisotto/magento2:2.1-develop-PR-port-16144
 - Merged commits:
   1. 66de2da
… ...', $array[] = works faster than invoking functions in PHP magento#16359
 - Merge Pull Request magento#16366 from lfluvisotto/magento2:2.1-develop-PR-port-16215
 - Merged commits:
   1. 1bb1b7a
   2. 4bcdb46
…for partial items invoice. It shows order's shipping & handling instead if invoiced shipping& handling charge magento#16352

 - Merge Pull Request magento#16352 from gelanivishal/magento2:2.1-develop-PR-port-15-14795
 - Merged commits:
   1. 346eed2
…king customer login attempts cleanup magento#16403

 - Merge Pull Request magento#16403 from rogyar/magento2:2.1-captcha-reset-frontend-it
 - Merged commits:
   1. a83ec42
Accepted Public Pull Requests:
 - magento#16359:  [Backport] array_push(...) calls behaving as '$array[] = ...', $array[] = works faster than invoking functions in PHP (by @lfluvisotto)
 - magento#16366: [Backport] PHPDoc (by @lfluvisotto)
 - magento#16347: [Backport 2.1] Captcha: Added integration test for checking admin login attempts cleanup (by @rogyar)
…for partial items invoice. It shows order's shipping & handling instead if invoiced shipping& handling charge magento#16352
Accepted Public Pull Requests:
 - magento#16403: [Backport 2.1] Captcha: Added integration tests for checking customer login attempts cleanup (by @rogyar)
 - magento#16352: [Backport] Invoice grid shows wrong shipping & handling for partial items invoice. It shows order's shipping & handling instead if invoiced shipping& handling charge (by @gelanivishal)
 - magento#16280: MAGETWO-61209: Backport - Fixed issue magento#7379 with mage/calendar when setting `numberOfM� (by @vasilii-b)


Fixed GitHub Issues:
 - magento#7379: Calendar widget (jQuery UI DatePicker) with numberOfMonths = 2 or more (reported by @atihomirov) has been fixed in magento#16280 by @vasilii-b in 2.1-develop branch
   Related commits:
     1. ce38bc8
@gelanivishal gelanivishal merged commit 05be531 into 2.1-develop Jun 30, 2018
gelanivishal pushed a commit that referenced this pull request Aug 11, 2018
MAGETWO-91762: [Magento Cloud] - MYSQL Message queue is fetching mess…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants