[Forwardport] magento/magento2#15255 unlock customer after password reset#33
Merged
gelanivishal merged 16 commits into2.3-developfrom Jun 20, 2018
Merged
[Forwardport] magento/magento2#15255 unlock customer after password reset#33gelanivishal merged 16 commits into2.3-developfrom
gelanivishal merged 16 commits into2.3-developfrom
Conversation
- Adding/updating action groups and elements to support file cleanup after tests
- Adding test files for upload tests
- Fixing/updating image action groups
…8-tech-debt-cleanup-background-attributes-for-banner
- Update special character image file to be cross compatible with all platforms - Update image cleanup action group to look for file names in image src attribute
- Loosen selector for Image name in src attribute
- Update missed data entity with old special character file name - Update expected background-position values - Use a more targeted selector for image upload preview - Update background-size tests to use visual select action group
- Update tests to handle cleaning up uploaded images better - Fix additional usages of background-position to use visual select
…ech-debt-cleanup-background-attributes-for-banner
…ech-debt-cleanup-background-attributes-for-banner
- Fixing flakiness in delete image action group
…8-tech-debt-cleanup-background-attributes-for-banner
…ech-debt-cleanup-background-attributes-for-banner
…8-tech-debt-cleanup-background-attributes-for-banner
…0828-tech-debt-cleanup-background-attributes-for-banner [obsessive] MAGETWO-90828: [Tech Debt] Cleanup Background Attributes for Banner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original Pull Request
magento#15534
Unlock customer after password reset
Fixed Issues (if relevant)
Manual testing scenarios
Contribution checklist