Enhanced Forge Server Installation Script and Configuration #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Changes Overview - Completely rewrote the installation script with improved error handling and logging - Streamlined Java version handling and Docker image configuration - Added robust version validation and compatibility checks - Improved MSH (Minecraft Server Hibernation) configuration and setup ## Key Improvements ### Installation Script - Added comprehensive error handling with descriptive messages - Implemented proper cleanup procedures and exit traps - Added timestamp-based logging for better debugging - Enhanced version validation and compatibility checking - Improved handling of Forge installation for different Minecraft versions - Added proper validation of downloaded files and installations ### Docker Configuration - Simplified Java version selection in docker images - Removed redundant J9 variants to reduce complexity - Updated image tags for better version clarity ### MSH Configuration - Added automatic MSH configuration generation with proper paths - Improved handling of unix_args.txt for newer Forge versions - Added proper symlink creation for Forge compatibility - Enhanced boolean handling for MSH configuration options ### Variables - Added FORGE_VERSION variable for better version control - Updated variable descriptions for clarity - Fixed boolean handling in environment variables
Mazuna
changed the title
|
Thank you for the PR to help improve the forge egg. |
BolverBlitz
requested changes
Feb 8, 2025
There was a problem hiding this comment.
- The FORGE_VERSION variable is required and does not accept latest like the minecraft
version, that will make it harder for the user to create a server. - You swaped the java versions so java 8 is the auto selected one, but i would argue a new player is more likly to choose a resent miencraft version so a newer Java version is required wich is the reason why i´ve had them go 21 > 17 > 16 ....
- The Forge Variable you added is not managable by the user.
Did you test the egg? I´ve imported it and it fails with the error "/mnt/install/install.sh: line 214: FORGE_SERVER_JAR: unbound variable"
|
Ah, I see the error now, I will fix it asap. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Overview
Key Improvements
Installation Script
Docker Configuration
MSH Configuration
Variables