-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix README.md #9
base: main
Are you sure you want to change the base?
Conversation
@@ -13,11 +12,13 @@ Display icons for filenames in ![Magit](https://github.com/magit/magit) buffers! | |||
</div> | |||
|
|||
# Preview | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This actually does work as expected because of the See, for example, Corfu's documentation, which similarly suggests using the The reason I suggest using the For example, with the following config:
If I've disabled the mode at runtime, and now want to evaluate my config file with this form in it, the minor mode will be re-enabled, which is a bit annoying. Using |
Thanks for taking your time to improve the package! If my analysis is mistaken or you would like to add something to the previous, please let me know. I would still like to accept the formatting changes to the README. |
Hello!
I saw
README.md
and fix some markdown errors.Also
use-package.el
documentation says::init
:config
:Summary: you must turn on mode in
:config
section, not an:init
.