feat!: abstract icon getter functions #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR abstracts the icon getter functions into two new variables:
magit-file-icons-icon-for-file-funcandmagit-file-icons-icon-for-dir-funcwhich will allow the package to support icon backends other thannerd-icons. These functions default to using nerd-icons functions for compatibility, but can be overriden with custom functions from any icon backend.This removes the dependency on nerd-icons, which will break user config if they are using nerd-icons and have not called
(require 'nerd-icons)before loading the package.This also updates the documentation with an example (using
all-the-icons) and updates the test files so tests can still run. The tests are only run using nerd-icons, however.Hopefully this is an improvement over #5, so let me know what you think! Thanks!