Add box component #804
Open
Add box component #804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add box component documentation Refactor with-scale file
✅ Deploy Preview for geist-ui ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov ReportBase: 98.85% // Head: 98.86% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #804 +/- ##
=======================================
Coverage 98.85% 98.86%
=======================================
Files 198 199 +1
Lines 3046 3071 +25
Branches 668 685 +17
=======================================
+ Hits 3011 3036 +25
Misses 34 34
Partials 1 1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Hdanzo
commented
Nov 17, 2022
components/box/box.tsx
Outdated
| }, | ||
| ); | ||
|
|
||
| // Box.displayName = 'GeistBox' |
There was a problem hiding this comment.
Forgot about this, I'll work on it
Apply formatting rules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Change information
Add box component
Add box component documentation
Refactor with-scale file
I had to add the scaling directly into the box component because the with-scale HOC would break the typing, maybe there's a better way of doing it, feel free to comment if so.
Closes #770