Update plugin installation and uninstallation paths to use the correct directory#7
Merged
geicht merged 2 commits intogeicht:masterfrom Jan 30, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the docker-compose Chocolatey package to use the new installation path C:\Program Files\Docker\cli-plugins\ instead of the deprecated C:\ProgramData\Docker\cli-plugins\ path, following changes in docker/cli#6713.
Changes:
- Updated installation and uninstallation paths from
C:\ProgramData\Docker\cli-plugins\toC:\Program Files\Docker\cli-plugins\ - Added backward compatibility cleanup in the install script to remove docker-compose from the old location
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| docker-compose/tools/chocolateyInstall.ps1 | Updated target directory path and added cleanup logic to remove files from the deprecated location during installation |
| docker-compose/tools/chocolateyUninstall.ps1 | Updated directory path to match the new installation location |
Comments suppressed due to low confidence (1)
docker-compose/tools/chocolateyInstall.ps1:11
- Creating directories in "C:\Program Files" requires elevated (administrator) privileges. While Chocolatey packages typically run with elevated privileges, this migration from ProgramData (which doesn't require admin rights for all operations) to Program Files changes the permission requirements. Ensure this is documented and that users are aware they need to run the installation with administrator privileges.
$executableTargetDir = 'C:\Program Files\Docker\cli-plugins\'
$executableTargetPath = Join-Path $executableTargetDir 'docker-compose.exe'
# create plugin directory if it doesn't exist
if (-not (Test-Path -Path $executableTargetDir)) {
$null = New-Item -Path $executableTargetDir -ItemType Directory
}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
v1v
reviewed
Jan 29, 2026
Owner
|
I have pushed the update to chocolatey. It should come out of review within a day or two: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to docker/cli#6713 the current installation path for
docker-composehas been deprecated.