Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support translations #5

Open
Zae opened this issue Jun 23, 2013 · 5 comments
Open

Support translations #5

Zae opened this issue Jun 23, 2013 · 5 comments
Labels
planned

Comments

@Zae
Copy link

Zae commented Jun 23, 2013

Right now the class uses the hardcoded string 'time=' to find the latency from the exec output, but when the ping program is localized the class incorrectly assumes the host is unreachable.

In dutch for example this should be 'tijd='.
@geerlingguy
Copy link
Owner

I would love to get Ping internationalized; I didn't realize ping was localized like that. Since I don't have too much experience with localization, I'd love your input (and anyone else's); is gettext the best/preferred way of doing localization in PHP at this time?

@Zae
Copy link
Author

Zae commented Jun 24, 2013

I think gettext is the perfect way to solve this.

@geerlingguy geerlingguy mentioned this issue Sep 5, 2016
Closed
@geerlingguy geerlingguy mentioned this issue Aug 26, 2019
Closed
@lubber-de lubber-de mentioned this issue Oct 22, 2019
Closed
@stale
Copy link

stale bot commented Mar 6, 2020

This issue has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark issues as stale.

@stale stale bot added the stale label Mar 6, 2020
@stale
Copy link

stale bot commented Apr 5, 2020

This issue has been closed due to inactivity. If you feel this is in error, please reopen the issue or file a new issue with the relevant details.

@stale stale bot closed this as completed Apr 5, 2020
@geerlingguy geerlingguy mentioned this issue Apr 17, 2020
Closed
@geerlingguy geerlingguy reopened this Apr 17, 2020
@stale
Copy link

stale bot commented Apr 17, 2020

This issue is no longer marked for closure.

@stale stale bot removed the stale label Apr 17, 2020
pixelbrackets added a commit to pixelbrackets/Ping that referenced this issue Aug 6, 2020
@pixelbrackets
Support locales in ping output
4ff7eb7 
Loosen the regex to search for a time value,
to support non-english output of the ping command.

Since the output is generic in all languages we dont
need to look for a specific english term.

Refs geerlingguy#5 Refs geerlingguy#49
@pixelbrackets pixelbrackets mentioned this issue Aug 6, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
planned
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Zae @geerlingguy