Reduce file permissions for config files to protect OAuth secrets #160
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clouatre
approved these changes
Oct 27, 2025
There was a problem hiding this comment.
Reviewed and tested locally on macOS.
Testing:
- ✅ All unit tests pass (44/44)
- ✅ Build succeeds without errors
- ✅ Code change is minimal and correct
- ✅ Verified current files are indeed 644 (world-readable)
Security Assessment:
This fixes a real security issue. OAuth tokens in ~/.mcp-auth/ are currently
world-readable (644), allowing any local user to steal credentials and access
Atlassian instances.
Code Quality:
- Follows Node.js fs.writeFile API correctly
- Applied consistently to both writeJsonFile and writeTextFile
- No breaking changes
- Matches security best practices for credential storage
LGTM! This should be merged, especially for users on shared/corporate systems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, configuration files under
~/.mcp-auth/are created with 644 permissions which allows all users to read the contents. These files contain OAuth tokens and PKCEs which should not be accessible to anyone but the user they belong to.This PR changes those file permissions to 600 so that only the current user can read them.