Repository navigation
docs: require fork-internal PRs by default (Hard Rule #20) - #2
Conversation
…ce#20) Add Hard Rule cheaper-inference#20: open PRs inside the geekjapan/OmniRoute fork (base geekjapan/OmniRoute:main) by default. Since this repo is a GitHub fork, GitHub's PR page and `gh pr create` default the base to upstream (diegosouzapw/OmniRoute) — override with `gh pr create --repo geekjapan/OmniRoute --base main`. Target upstream only when explicitly preparing an upstream contribution. Reflected into all agent scopes: CLAUDE.md (canonical), AGENTS.md (Hard Rules + Fork/Upstream Workflow), GEMINI.md, and openspec/config.yaml (context + tasks rule).
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces Hard Rule cheaper-inference#20 across AGENTS.md, CLAUDE.md, GEMINI.md, and openspec/config.yaml, instructing developers to default to opening pull requests inside the geekjapan/OmniRoute fork rather than the upstream repository. Feedback is provided regarding an accidental indentation change in CLAUDE.md that breaks markdown list formatting.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| `fix/*`/`feat/*` — other sessions keep their own; delete only the branches you created, by name. | ||
| 5. **Never touch another session's worktree, branch, or uncommitted changes.** If `git worktree | ||
| list` shows worktrees you didn't create, leave them alone. End every session with the main | ||
| list` shows worktrees you didn't create, leave them alone. End every session with the main |
There was a problem hiding this comment.
The indentation of this line was accidentally removed, which breaks the markdown list formatting. It should be indented with three spaces to align with the list item above:
list` shows worktrees you didn't create, leave them alone. End every session with the mainThere was a problem hiding this comment.
⚠️ Not ready to approve
CLAUDE.md has a markdown formatting regression where an inline code span is split across lines (git worktree / list), which will render incorrectly and should be fixed before merging.
Pull request overview
Updates the repo’s “Hard Rules” documentation across agent scopes to require creating pull requests against the fork’s geekjapan/OmniRoute:main by default (to avoid GitHub/gh defaulting PR bases to the upstream parent repo).
Changes:
- Add Hard Rule cheaper-inference#20 to
CLAUDE.md,AGENTS.md, andGEMINI.mddescribing the fork-internal PR default and the requiredgh pr create --repo geekjapan/OmniRoute --base main …override. - Mirror the same rule into OpenSpec agent context (
openspec/config.yaml) and OpenSpectasksrules.
Commands run: not run (docs-only changes; command execution not available in this review environment)
Coverage (custom): not run
File summaries
| File | Description |
|---|---|
| openspec/config.yaml | Mirrors Hard Rule cheaper-inference#20 into the OpenSpec context and task rules so spec-driven workflows default to fork-internal PRs. |
| GEMINI.md | Adds Hard Rule cheaper-inference#20 to Gemini agent rules to prevent accidentally targeting upstream in PR creation. |
| CLAUDE.md | Adds Hard Rule cheaper-inference#20 to canonical rules; also touches Worktree Isolation section formatting. |
| AGENTS.md | Adds Hard Rule cheaper-inference#20 and reinforces it in the “Fork / Upstream Workflow” section for non-Claude agents. |
Copilot's findings
- Files reviewed: 4/4 changed files
- Comments generated: 1
Note
Your feedback helps us improve the quality of this feature.
Please use 👍 or 👎 to tell us whether this assessment is correct.
| 5. **Never touch another session's worktree, branch, or uncommitted changes.** If `git worktree | ||
| list` shows worktrees you didn't create, leave them alone. End every session with the main | ||
| list` shows worktrees you didn't create, leave them alone. End every session with the main | ||
| checkout back on the branch it started on (the active `release/vX.Y.Z`, never `main`). |
Summary
Fork-internal PR (base:
geekjapan/OmniRoute:main) — does not target upstream. Follow-up to #1 (which merged before this commit landed).Adds Hard Rule cheaper-inference#20: open pull requests inside the
geekjapan/OmniRoutefork by default (basegeekjapan/OmniRoute:main). Because this repo is a GitHub fork ofdiegosouzapw/OmniRoute, GitHub's PR page andgh pr createdefault the base to the upstream parent, so it must be overridden:Target upstream only when explicitly preparing an upstream contribution.
Reflected into all agent scopes
CLAUDE.md(canonical) — Hard Rule feat: v0.2.0 — advanced routing services, cost analytics, pricing overhaul cheaper-inference/OmniRoute#20AGENTS.md(Codex) — Hard Rule feat: v0.2.0 — advanced routing services, cost analytics, pricing overhaul cheaper-inference/OmniRoute#20 + "Fork / Upstream Workflow" default noteGEMINI.md(Gemini) — Hard Rule feat: v0.2.0 — advanced routing services, cost analytics, pricing overhaul cheaper-inference/OmniRoute#20openspec/config.yaml— context hard-rules + atasksrule(Also recorded in the operator-scope agent memory.)