Merge pull request #23 from Bl00D4NGEL/implement-array-access-generics

Feat: Genericly implement ArrayAccess for Collection and Paginator
geekcell · Dec 19, 2023 · 7b6bc14 · 7b6bc14
2 parents df3f12b + d654dbe
commit 7b6bc14
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/src/Domain/Collection.php b/src/Domain/Collection.php
@@ -8,15 +8,14 @@
 
 /**
  * @template T of object
- * @extends \IteratorAggregate<T>
+ * @implements \IteratorAggregate<T>
+ * @implements \ArrayAccess<mixed, T>
  */
 class Collection implements \ArrayAccess, \Countable, \IteratorAggregate
 {
     /**
      * @param T[] $items
      * @param class-string<T>|null $itemType
-     *
-     * @throws Assert\AssertionFailedException
      */
     final public function __construct(
         private readonly array $items = [],
@@ -31,10 +30,8 @@ final public function __construct(
      * Add one or more items to the collection. It **does not** modify the
      * current collection, but returns a new one.
      *
-     * @param mixed $item  One or more items to add to the collection.
+     * @param mixed $item One or more items to add to the collection.
      * @return static
-     *
-     * @throws Assert\AssertionFailedException
      */
     public function add(mixed $item): static
     {

diff --git a/src/Infrastructure/InMemory/Paginator.php b/src/Infrastructure/InMemory/Paginator.php
@@ -13,7 +13,8 @@
 
 /**
  * @template T of object
- * @extends PaginatorInterface<T>
+ * @implements PaginatorInterface<T>
+ * @implements ArrayAccess<mixed, T>
  */
 class Paginator implements PaginatorInterface, ArrayAccess
 {