Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove AWS SDKv2 #30

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Remove AWS SDKv2 #30

wants to merge 3 commits into from

Conversation

Ic3w0lf
Copy link
Member

@Ic3w0lf Ic3w0lf commented Aug 8, 2024

What it solves

  • Replace any SDKv2 references
  • Log output become incomplete as the tail starts after the container has been started. I hate this SDK

TODO

  • Create LogStream in the GHA and start LiveTail BEFORE we wait for the container to be up (should solve missing log output=
  • Update README with required IAM policy

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request
  • Pull request title is brief and descriptive (for a changelog entry)

Reviewing Maintainer

  • Label as breaking if this is a large fundamental change
  • Label as either automation, bug, documentation, or enhancement
  • Label as bump:patch, bump:minor, or bump:major if this PR should create a new release

@MrNoyceCosta
Copy link

@Ic3w0lf When will his be merged? I'm getting some odd timeout errors when running the 4.1.0 version and would like to check if this PR fixes the issue.

FYI Error: Task did not stop successfully. Error: TimeoutError. State: undefined.

@Ic3w0lf
Copy link
Member Author

Ic3w0lf commented Aug 19, 2024

Hey @MrNoyceCosta

I still need to fix some issues regarding the action not outputting all logs. However, the error you get sounds like maybe your task runs longer than 5 minutes or takes more time to start up. Did you try increasing the task-stopped-max-wait-time from 300 to something higher? Alternatively, maybe try increasing the task-start-max-wait-time which controls how long the action will wait for the task to get to the RUNNING state.

Also, I think you can define branch names when you use this action. E.g. like geekcell/github-action-aws-ecs-run-task@sdkv3-rep or commit hashes.

Best regards

@MrNoyceCosta
Copy link

@Ic3w0lf Thanks for your reply. The task could be running for quite some time. What is the max value that can be set for task-stopped-max-wait-time?

@Ic3w0lf
Copy link
Member Author

Ic3w0lf commented Aug 19, 2024

@Ic3w0lf Thanks for your reply. The task could be running for quite some time. What is the max value that can be set for task-stopped-max-wait-time?

@MrNoyceCosta I don't there is a hard limit here (at least I couldn't find any in the documentation). However, please be careful to not have your GitHub Actions cost explode if you set the limit too high. You can also set the task-wait-until-stopped parameter to false to avoid having the GitHub Action wait for the task to finish. The Action will then simply start the action and return, not providing any log output or status.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants