-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Update environment.yml to include conda-forge #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
add conda-forge channel for Issue gedeck#56
|
@gedeck I can temporarily rollback the version of sci-kit learn to 1.2? This appears to be an issue with scikit 1.3 and there is a pull request open that is currently being worked on. Edit: I'll try my hand at making changes to the Github Action build as well to build with conda/mamba instead of pip. Edit 2: Seems like it may be fixed! |
|
Yes, fix sklearn version to 1.2 until the issue is resolved |
|
Instead of replacing the pip install in github/workflow, add extra jobs for building with conda and/or mamba. As the pip install run already checks different Python versions, we could restrict conda/mamba to the latest Python version. |
|
Okay, I’ll roll that up in a later pull request.
…On Thu, Jul 6, 2023 at 18:10 gedeck ***@***.***> wrote:
Instead of replacing the pip install in github/workflow, add extra jobs
for building with conda and/or mamba. As the pip install run already checks
different Python versions, we could restrict conda/mamba to the latest
Python version.
—
Reply to this email directly, view it on GitHub
<#57 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHM4WCZW5SN7YE3CSWHJWTDXO4ZTRANCNFSM6AAAAAA2APLAAA>
.
You are receiving this because you authored the thread.Message ID:
<gedeck/practical-statistics-for-data-scientists/pull/57/c1624374880@
github.com>
|
|
Fixed in scikit-learn-contrib/imbalanced-learn#999. |
|
@glemaitre Thank you very much to being responsive. |
gregorywaynepower
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added fault channel as well
gedeck
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to approve this, so that you can merge it when it is ready
|
@gedeck I don’t have write access to the repo, so I don’t believe I can merge it. |
|
I merged it now |
add conda-forge channel for Issue #56
Closes #56