Skip to content

Conversation

@gregorywaynepower
Copy link
Contributor

@gregorywaynepower gregorywaynepower commented Jul 6, 2023

add conda-forge channel for Issue #56

Closes #56

add conda-forge channel for Issue gedeck#56
@gregorywaynepower
Copy link
Contributor Author

gregorywaynepower commented Jul 6, 2023

@gedeck I can temporarily rollback the version of sci-kit learn to 1.2? This appears to be an issue with scikit 1.3 and there is a pull request open that is currently being worked on.

Edit: I'll try my hand at making changes to the Github Action build as well to build with conda/mamba instead of pip.

Edit 2: Seems like it may be fixed!

@gedeck
Copy link
Owner

gedeck commented Jul 6, 2023

Yes, fix sklearn version to 1.2 until the issue is resolved

@gedeck
Copy link
Owner

gedeck commented Jul 6, 2023

Instead of replacing the pip install in github/workflow, add extra jobs for building with conda and/or mamba. As the pip install run already checks different Python versions, we could restrict conda/mamba to the latest Python version.

@gregorywaynepower
Copy link
Contributor Author

gregorywaynepower commented Jul 6, 2023 via email

@glemaitre
Copy link

Fixed in scikit-learn-contrib/imbalanced-learn#999.
I'm going to make a release ASAP.

@gedeck
Copy link
Owner

gedeck commented Jul 7, 2023

@glemaitre Thank you very much to being responsive.

@gregorywaynepower gregorywaynepower changed the title Update environment.yml Update environment.yml to include conda-forge Jul 9, 2023
Copy link
Contributor Author

@gregorywaynepower gregorywaynepower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added fault channel as well

Copy link
Owner

@gedeck gedeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to approve this, so that you can merge it when it is ready

@gregorywaynepower
Copy link
Contributor Author

gregorywaynepower commented Jul 9, 2023

@gedeck I don’t have write access to the repo, so I don’t believe I can merge it.

@gedeck gedeck merged commit da5dbc2 into gedeck:master Jul 10, 2023
@gedeck
Copy link
Owner

gedeck commented Jul 10, 2023

I merged it now

@gregorywaynepower gregorywaynepower deleted the patch-1 branch July 11, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Anaconda - ResolvePackageNotFound

3 participants