-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make robust #3
Make robust #3
Conversation
Wonderful. Thanks. Some checks are not passing. That's why I haven't merged just yet. |
Yes, this is still in the draft state. The checks are failing because I require the development version of tidync. The workaround for the older is already in place. It just has to be activated as default. |
Yes, calling this v2.0 makes sens. However, we haven't tagged anything yet and haven't created releases. Let me know before you create a release so that I can sync it to my Zenodo. |
Is there a reason for changing from |
The reason I changed |
This PR makes map2tidy more robust (solves #2):
do_chunks
,ncores
)julian
,365_day
(a.k.anoleap
),366_day
,360_day
)Handling of calendars was achieved by returning strings in the 'datetime' column of the tidy data.frames. Parsing of these strings, if necessary, must be done afterwards by the user. Then days such as
"2021-02-30"
(valid in a360_day
-calendar), can be handled accordingly.