Skip to content

Conversation

@magistau
Copy link

@magistau magistau commented Nov 3, 2023

This error kind was introduced with bb32803 (see #1), but pallet-contracts was not updated after adding it.

Note that adding a variant to an public exhaustive enum is a breaking change.
See https://doc.rust-lang.org/cargo/reference/semver.html#enum-variant-new.

This error kind was introduced with bb32803 (see #1),
but pallet-contracts was not updated after adding it.

Note that adding a variant to an public exhaustive enum
is a breaking change.
See https://doc.rust-lang.org/cargo/reference/semver.html#enum-variant-new.
@ukint-vs
Copy link
Member

ukint-vs commented Nov 3, 2023

This was done intentionally to have as minimal changes to upstream as possible since we are not using contracts pallet and we need to rebase each time. But we can just put unreachable maybe in grow fn.

@magistau
Copy link
Author

magistau commented Nov 3, 2023

Well, pallet-contracts doesn't compile at all without handling MemoryGrow and this change is simple enough not to cause complex conflicts

@ukint-vs ukint-vs merged commit c19ce2c into master Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants