Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gstd): add the missing dbg! macro #3610

Merged
merged 2 commits into from
Dec 20, 2023
Merged

feat(gstd): add the missing dbg! macro #3610

merged 2 commits into from
Dec 20, 2023

Conversation

shamilsan
Copy link
Contributor

@gear-tech/dev

holykol
holykol approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@holykol holykol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool

@shamilsan shamilsan added A0-pleasereview PR is ready to be reviewed by the team B1-releasenotes The feature deserves to be added to the Release Notes labels Dec 20, 2023
@shamilsan shamilsan merged commit bd9e6e9 into master Dec 20, 2023
11 checks passed
@shamilsan shamilsan deleted the sy-add-dbg-macro branch December 20, 2023 17:30
btwiuse pushed a commit to btwiuse/gdbg that referenced this pull request Jan 16, 2024
use {:?} not {:#?}
66b025b 
Since the same feature has been added to gstd (gear-tech/gear#3610)
this crate should've been deprecated

However, the compact version of dbg! proposed in rust-lang/rust#82778
does look better

So let me repurpose this crate as the compact implementation of dbg! for gear smart contracts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ukint-vs ukint-vs ukint-vs approved these changes

@holykol holykol holykol approved these changes

Assignees
No one assigned
Labels
A0-pleasereview PR is ready to be reviewed by the team B1-releasenotes The feature deserves to be added to the Release Notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shamilsan @holykol @ukint-vs