feat: Update substrate to v0.9.43 by ukint-vs · Pull Request #3446 · gear-tech/gear

ukint-vs · 2023-10-24T06:08:02Z

update substrate to v0.9.42:

update pallet_balances config
balances set_balance -> force_set_balance
update client service
Nomination pools migration v5 Reward pool migration fix paritytech/substrate#13715
Offences migration to v1 Removes ReportsByKindIndex paritytech/substrate#13936
Impl OnUnbalanced for OffsetPoolDust in staking-rewards
update gsdk verify

update substrate to v0.9.43:

add weights in pallet_sudo
update pallet-staking-rewards tests (stash is controller from now on)
Add migration to set current pallet versions to pallets that were added after genesis

todo:

update weights
fix balances weights

@gear-tech/dev

gclient/src/api/calls.rs

breathx · 2023-10-29T17:00:47Z

node/service/src/lib.rs

        RuntimeApiCollection<StateBackend = sc_client_api::StateBackendFor<FullBackend, Block>>,
    ExecutorDispatch: NativeExecutionDispatch + 'static,
 {
-    if config.keystore_remote.is_some() {


Does remote keystore now supported? hm

node/service/src/lib.rs

node/service/src/rpc/mod.rs

breathx · 2023-10-29T18:19:56Z

runtime/vara/src/migrations.rs

+pub struct NominationPoolsMigrationV4OldPallet;
+impl Get<Perbill> for NominationPoolsMigrationV4OldPallet {
+    fn get() -> Perbill {
+        Perbill::from_percent(10)


any comments on that?

https://github.com/paritytech/polkadot-sdk/blob/0aeab381380107a6462fea240181f6e2a78f21b8/polkadot/runtime/westend/src/lib.rs#L1511C1-L1511C1

pallets/staking-rewards/src/mock.rs

breathx · 2023-10-29T18:23:04Z

pallets/staking-rewards/src/lib.rs

    }
 }

+// DustRemoval handler


what was the problem of previous impl? trait bounds? than add todo to remove initial one

Conflicting implementation. Since balances::DustHandler switched to fungible::Credit from Imbalance. But we are using Imbalance in fn align_supply

Yeah, add todo pls

We don't need Todo. Both structs are for two different implementation and purposes

gshep

🥇

shamilsan

Big deal 👍

NikVolf · 2023-11-08T11:45:08Z

This should go in separate release

NikVolf

Isolated testable release for it please

NikVolf · 2023-12-01T10:43:03Z

Can we finally merge it and make update to 0.43 ASAP?

breathx · 2023-12-11T14:22:28Z

To be merged into separate release branch, isn't it? @ukint-vs

ukint-vs added 30 commits July 16, 2023 13:12

Update substrate to v0.9.42

38181d6

Update runtimes

38f2380

TypeInfo HandleKind

e7126e5

Update node/service

3a63a0a

Use verify instead of removed verify_weak

9fe9452

gear-replay-cli update

746d71f

gsdk update

d951683

Update mocks

72ba5f6

misc update fuzzer, integration tests

285edb8

Merge branch 'master' into vs/substrate-v0.9.43-2

0a1e799

update mocks

5c2483b

update node test

1059913

skip missing weights

b738016

fix resume_program_works: account ED

2b8e17f

Nomination pools migration v5: rewardpool fix

a1cea79

nom pools MigrateV3ToV5, offences MigrateToV1

9d1a05e

update gsdk metadata

f4224ab

update gclient

c9523f6

Merge branch 'master' into vs/substrate-v0.9.43-2

cb15048

Merge branch 'master' into vs/substrate-v0.9.43-2

ece5834

remove validator-set pallet

bda819a

clean up runtime-interface

d1256b6

clean up common

7f2bb4d

clean up lazy-pages

e649eba

clean up utils

adae247

clean up node

87eccb8

others

7c94b27

update Cargo.lock

20bbe52

Merge branch 'master' into vs/remove-unused-deps

5edd18f

fiz fuzzer

2aeea33

fix migration

3510f31

ukint-vs force-pushed the vs/substrate-v0.9.43-2 branch from e1a52ca to 3510f31 Compare October 29, 2023 15:37

ukint-vs requested review from breathx and ekovalev October 29, 2023 15:44

update gsdk metadata

b1b92b1

breathx approved these changes Oct 29, 2023

View reviewed changes

ukint-vs added 5 commits October 30, 2023 17:43

resolve comments

87bd13f

Update weights

2682aec

disable hw benches for dev node

7cab152

ws-port -> rpc-port

c4af7e3

clippy

19ce6b3

gshep approved these changes Nov 3, 2023

View reviewed changes

ukint-vs force-pushed the vs/substrate-v0.9.43-2 branch from 5e65f91 to 5a182a7 Compare November 7, 2023 18:59

set correct pallets storage version via migration

2f3ecab

ukint-vs force-pushed the vs/substrate-v0.9.43-2 branch from 5a182a7 to 2f3ecab Compare November 7, 2023 19:02

ukint-vs added 2 commits November 8, 2023 12:36

Merge branch 'master' into vs/substrate-v0.9.43-2

a0abfd4

Update Cargo.lock

b48e2bd

shamilsan approved these changes Nov 8, 2023

View reviewed changes

Merge branch 'master' into vs/substrate-v0.9.43-2

dcbec86

NikVolf requested changes Nov 8, 2023

View reviewed changes

breathx added A5-dontmerge PR should not be merged yet and removed A0-pleasereview PR is ready to be reviewed by the team labels Nov 10, 2023

ukint-vs added 3 commits December 1, 2023 11:50

Merge branch 'master' into vs/substrate-v0.9.43-2

be06b0a

use new logic flag

8a37b9a

fix cargo_metadata

56142f5

ukint-vs added the A0-pleasereview PR is ready to be reviewed by the team label Dec 1, 2023

breathx closed this Dec 11, 2023

Conversation

ukint-vs commented Oct 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

breathx Oct 29, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

breathx Oct 29, 2023

Choose a reason for hiding this comment

Uh oh!

ukint-vs Oct 30, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

breathx Oct 29, 2023

Choose a reason for hiding this comment

Uh oh!

ukint-vs Oct 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

breathx Oct 31, 2023

Choose a reason for hiding this comment

Uh oh!

ukint-vs Oct 31, 2023

Choose a reason for hiding this comment

Uh oh!

gshep left a comment

Choose a reason for hiding this comment

Uh oh!

shamilsan left a comment

Choose a reason for hiding this comment

Uh oh!

NikVolf commented Nov 8, 2023

Uh oh!

NikVolf left a comment

Choose a reason for hiding this comment

Uh oh!

NikVolf commented Dec 1, 2023

Uh oh!

breathx commented Dec 11, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ukint-vs commented Oct 24, 2023 •

edited

Loading

ukint-vs Oct 30, 2023 •

edited

Loading