Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pcells #45

Merged
merged 2 commits into from
Oct 9, 2022
Merged

add pcells #45

merged 2 commits into from
Oct 9, 2022

Conversation

joamatab
Copy link
Contributor

@joamatab joamatab commented Oct 9, 2022

add pcells

thanks to @atorkmabrains and @RehabSayed-G

@sourcery-ai
Copy link

sourcery-ai bot commented Oct 9, 2022

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.35%.

Quality metrics Before After Change
Complexity 3.81 ⭐ 7.10 ⭐ 3.29 👎
Method Length 199.17 😞 203.50 😞 4.33 👎
Working memory 15.08 😞 12.65 😞 -2.43 👍
Quality 45.67% 😞 46.02% 😞 0.35% 👍
Other metrics Before After Change
Lines 263 123 -140
Changed files Quality Before Quality After Quality Change
docs/write_components_doc.py 59.70% 🙂 41.94% 😞 -17.76% 👎
sky130/init.py 54.36% 🙂 54.58% 🙂 0.22% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@joamatab joamatab merged commit 7365ad0 into main Oct 9, 2022
@joamatab joamatab deleted the 010 branch March 6, 2023 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant