Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

007 #2

Merged
merged 5 commits into from
Jun 3, 2022
Merged

007 #2

merged 5 commits into from
Jun 3, 2022

Conversation

joamatab
Copy link
Contributor

@joamatab joamatab commented Jun 3, 2022

works with latest gdsfactory

@proppy

@joamatab joamatab merged commit de98975 into main Jun 3, 2022
@sourcery-ai
Copy link

sourcery-ai bot commented Jun 3, 2022

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 1.00%.

Quality metrics Before After Change
Complexity 0.99 ⭐ 1.00 ⭐ 0.01 👎
Method Length 1558.40 ⛔ 1571.20 ⛔ 12.80 👎
Working memory 9.73 🙂 10.39 😞 0.66 👎
Quality 50.35% 🙂 49.35% 😞 -1.00% 👎
Other metrics Before After Change
Lines 1604 1621 17
Changed files Quality Before Quality After Quality Change
setup.py 69.24% 🙂 67.97% 🙂 -1.27% 👎
sky130/init.py 78.70% ⭐ 69.69% 🙂 -9.01% 👎
sky130/components.py 45.10% 😞 43.53% 😞 -1.57% 👎
sky130/layers.py 60.38% 🙂 60.38% 🙂 0.00%
sky130/tech.py 74.85% 🙂 74.85% 🙂 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

sourcery-ai bot pushed a commit that referenced this pull request Sep 8, 2022
@joamatab joamatab deleted the 007 branch March 6, 2023 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant