Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crear template para las PRs #9

Closed
mdelapenya opened this issue Sep 8, 2019 · 0 comments · Fixed by #10
Closed

Crear template para las PRs #9

mdelapenya opened this issue Sep 8, 2019 · 0 comments · Fixed by #10
Assignees
@mdelapenya
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Milestone
Add crud plants e...

Comments

@mdelapenya
Copy link
Member

La idea es poder definir un template de PR, de modo que ayuden a los revisores a entender el contexto y las consideraciones realizadas a la hora de enviar una PR.
@mdelapenya mdelapenya added documentation Improvements or additions to documentation enhancement New feature or request labels Sep 8, 2019
@mdelapenya mdelapenya self-assigned this Sep 8, 2019
mdelapenya added a commit to mdelapenya/linneo that referenced this issue Sep 8, 2019
@mdelapenya
(gdgtoledo#9) Add PR template
6398cb8
mdelapenya added a commit to mdelapenya/linneo that referenced this issue Sep 8, 2019
@mdelapenya
(gdgtoledo#9) Add PR template
d7984b1
@mdelapenya mdelapenya mentioned this issue Sep 8, 2019
Merged
11 tasks
mdelapenya added a commit to mdelapenya/linneo that referenced this issue Sep 9, 2019
@mdelapenya
(gdgtoledo#9) Add PR template
3d52e46
mdelapenya added a commit to mdelapenya/linneo that referenced this issue Sep 9, 2019
@mdelapenya
(gdgtoledo#9) Remove item related to comments
ce1096e 
I don't like comments in code, I prefer code be self-explanative.
They are very rarely needed and then it's when I'd like people to check it.
On the other hand, I'm totally OK with removing it
mdelapenya added a commit to mdelapenya/linneo that referenced this issue Sep 10, 2019
@mdelapenya
(gdgtoledo#9) Add discussed items
95a5522
mdelapenya added a commit that referenced this issue Sep 10, 2019
@mdelapenya
Merge pull request #10 from mdelapenya/9-pr-template
aa8d52c 
(#9) Add PR template
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mdelapenya mdelapenya

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
Add crud plants endpoints
Development

Successfully merging a pull request may close this issue.

(#9) Add PR template mdelapenya/linneo
2 participants
@mdelapenya @javierlopezdeancos