-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement support for requiring dependency version ranges #82
Conversation
f49e88d
to
925a1fd
Compare
I think so. Let's go for that then. I didn't look at the implementation yet but the syntax is ok. Could you please add some tests as well? |
Sure, I was waiting for an OK for the syntax before spending time on writing tests :) |
This MR does not break API right? Just so I know how to version the release once it's merged. |
It doesn't break API. If a crate starts using more complex version expressions then it needs to be able to actually handle them though: it will get them passed as |
925a1fd
to
c5a3943
Compare
Added two simple tests for this. |
Looks like this test is failing on CI: https://github.com/gdesmott/system-deps/actions/runs/6695863075/job/18192357484?pr=82 (Yeah I need the fix the other jobs) |
I just did so you can rebase your branch for easy CI testing. |
c5a3943
to
a09f0d8
Compare
This now supports expressions in the form * "1.2" or ">= 1.2" for at least version 1.2 * ">= 1.2, < 2.0" for at least version 1.2 and less than version 2.0 Fixes gdesmott#60
a09f0d8
to
c2011f3
Compare
Because pkgconf and pkg-config have completely different error messages. I've added both of them now. |
Thanks for the patch. I just released |
This now supports expressions in the form
Fixes #60
@gdesmott Does this look reasonable to you? As discussed, semver can't really be used here because pkg-config versions don't follow semver. A version of "1.2" is semver ">= 1.2, < 2.0" and that is more semantics than pkg-config versions have.