Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"no field ld_args on type pkg_config::Library" on nightly #94

Closed
dimbleby opened this issue Jun 18, 2024 · 4 comments · Fixed by #95
Closed

"no field ld_args on type pkg_config::Library" on nightly #94

dimbleby opened this issue Jun 18, 2024 · 4 comments · Fixed by #95

Comments

@dimbleby
Copy link

running a CI pipeline against nightly rust

error[E0609]: no field `ld_args` on type `pkg_config::Library`
    --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/system-deps-7.0.0/src/lib.rs:1068:24
     |
1068 |             ld_args: l.ld_args,
     |                        ^^^^^^^ unknown field
     |
     = note: available fields are: `libs`, `link_paths`, `frameworks`, `framework_paths`, `include_paths` ... and 2 others

For more information about this error, try `rustc --explain E0609`.
error: could not compile `system-deps` (lib) due to 1 previous error

maybe you already know about this, maybe this is a nightly rust problem and not a system-deps problem, certainly it's not important to me so long as it is happening only on nightly - but I figured I should let you know about it in case work is needed

@gdesmott
Copy link
Owner

Thanks for the info, I was not aware of this problem.

That's really strange, why would Library.ld_args be missing with nightly?

@sdroege @amyspark : any idea?

@sdroege
Copy link

sdroege commented Jun 18, 2024

I don't know. It's always there since pkg-config-rs 0.3.24. Maybe that CI is using an ancient pkg-config-rs version?

@gdesmott
Copy link
Owner

Good point, we should have bumped the minimal version required!

Looks like it's from 0.3.25 actually.

gdesmott added a commit that referenced this issue Jun 18, 2024
That's the version which introduced Library.ld_args that we are now
using.

Fix #94
@dimbleby
Copy link
Author

ah yes, I also test with minimal versions - I hadn't realised that was the specific test that was failing

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants