Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run pre-commit run --all #196

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Run pre-commit run --all #196

merged 1 commit into from
Aug 22, 2024

Conversation

shoeffner
Copy link
Collaborator

As a preparation for the PR for #192, I ran pre-commit run --all and commit the changes to a separate branch now.

This is the result, mostly some changed JSON files and a little bit of black formatting.

All Submissions

Describe your environment

Follow best practices

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you followed the guidelines in our Contribution Guide?
  • Have you read the Code of Conduct?
  • Do your changes in a seperate branch. Branches MUST have descriptive names.
  • Have you merged the latest changes from upstream to your branch?

Describe the PR

  • What kind of change does this PR introduce?
    • It formats some JSON files, a little bit of Python code and one missing EOL
  • Why is this change required? What problem does it solve?
    • It is not required, but it makes working with pre-commit a little easier to have a "clean base" – otherwise, future changes might suddenly reformat a while file for minor changes.
  • Screenshots (if appropriate)
  • Put Closes #ISSUE_NUMBER to the end of this pull request

Testing

  • Have you used tox and/or pytest for testing the changes? pytest, run-tests.sh
  • Did the local testing ran successfully? yes, if changing DV_VERSION to 6.3.
  • Did the Continous Integration testing (Travis-CI) ran successfully?

Commits

  • Have descriptive commit messages with a short title (first line).
  • Use the commit message template
  • Put Closes #ISSUE_NUMBER in your commit messages to auto-close the issue that it fixes (if such).

Others

  • Is there anything you need from someone else? No.

Code contribution

  • Have you used pre-commit? Yes, pre-commit run --all :)
  • Have you formatted your code with black prior to submission (e. g. via pre-commit)? yes
  • Have you written new tests for your changes? No
  • Have you ran mypy on your changes successfully? Not attempted
  • Have you documented your update (Docstrings and/or Docs)? No
  • Do your changes require additional changes to the documentation? No

Closes #194

@shoeffner shoeffner mentioned this pull request Jul 19, 2024
30 tasks
@JR-1991 JR-1991 self-requested a review July 19, 2024 07:26
@JR-1991 JR-1991 self-assigned this Jul 19, 2024
@JR-1991 JR-1991 added the pkg:pkg Package related activities label Jul 19, 2024
@JR-1991
Copy link
Member

JR-1991 commented Jul 19, 2024

Looks good to me, thanks! Approved.

@JR-1991 JR-1991 added this to the 0.3.4 milestone Jul 19, 2024
@JR-1991 JR-1991 merged commit 0accb58 into gdcc:main Aug 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:pkg Package related activities
Projects
Development

Successfully merging this pull request may close these issues.

Run pre-commit run --all to unify code formatting
2 participants