Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to ORCID and ROR support #22

Merged
merged 33 commits into from
Sep 25, 2024

Conversation

qqmyers
Copy link
Member

@qqmyers qqmyers commented Jul 15, 2024

Multiple changes to support parent/managed fields, fixes/improvements. The parent/managed field changes work with changes being submitted for Dataverse 6.4. The other bug fixes/improvements should be backward compatible.

  • Support managed fields
    • Handle requirement to show author before affiliation when identifier field is last author child
    • Allow author IDType and Identifier fields to display when a plain text entry is selected rather than an ORCID.
    • Handle ROR for author affiliation field only - remove duplicate from normal author field display
  • Use util methods for storing local data
  • Fix error/plain text handling
  • Fix behavior with 0 lookup results
  • Fix prioritization of locally stored vals
  • Change display to match 'family, given' order as in author field
  • Change separator to ; (to distinguish from , in user name)
  • Handle getting no results from ORCID when plain text is allowed
  • Accessibility - ORCID and ROR and LocalContexts: allow tabbing to entry and to clear button, focus/move cursor to type-in when enter key is used to select either
  • Fix ROR icon size

Planning to add some documentation/perhaps rearrange scripts/examples to make it clearer which ones are potentially production usable versus one-off demos. Will link DV PR(s) when those are ready. Also will add :CVocConf setting.

image

image

image

qqmyers added 18 commits July 12, 2024 14:00
FWIW: Sort needs to handle 3 cases - one or the other of the entries has the condition, or both do/don't. Using Number converts true/false to 1/0 and substracting the test on a from the one on b gives the right 3 values.
support managed fields
use util methods for storing local data
fix error/plain text handling
fix behavior with 0 lookup results
fix prioritization of locally stored vals
change display to match family, given in author field
change separator to ;
@qqmyers qqmyers marked this pull request as ready for review July 22, 2024 18:07
@qqmyers
Copy link
Member Author

qqmyers commented Sep 25, 2024

With IQSS/dataverse#10712 merged, I'll go ahead and merge this so we're 6.4 ready!

@qqmyers qqmyers merged commit 23f1ee4 into gdcc:main Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants