-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement a greedy version of Kernel Inducing Points #686
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a couple of other minor documentation fixes. There's also the matter of whether to pass the intermediate state as a parameter, or whether to keep it internal - I currently think it should be a private member of GreedyKernelInducingPoints
, but I'm open to have my mind changed if there's something I've overlooked!
Co-authored-by: rg936672 <[email protected]>
Co-authored-by: rg936672 <[email protected]>
Co-authored-by: rg936672 <[email protected]>
Co-authored-by: rg936672 <[email protected]>
…y data already existing in the dataset
PR Type
Description
Adds coresubset algorithm implementing a greedy version of the KIP algorithm from https://arxiv.org/pdf/2011.00050.
Refactors
inverse.py
to beleast_squares.py
to be more generally useful.How Has This Been Tested?
Adds corresponding unit tests.
Does this PR introduce a breaking change?
(Write your answer here.)
Screenshots
(Write your answer here.)
Checklist before requesting a review