-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Introduce Yubico's Modhex for Conversion #1105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything else looks pretty good to me.
3307fb7
to
758ff9b
Compare
Signed-off-by: İlteriş Yağıztegin Eroğlu [email protected] |
Are there any updates on the merging of this PR? |
Hey! This pull request has gotten rather old and that's our fault. This project stopped being actively maintained for a while and it looks like your pull request has started to gather dust. Would you be able to update your branch to the latest version of CyberChef and we'll give it a review? |
Heya! It sure did get dust 😅, I'll try re{bas,factor}ing the code to current CyberChef later today (June 12th). Will poke when its done. |
758ff9b
to
eef51a0
Compare
@a3957273 I think this should do it, I couldn't get tests working on macOS; so tests may or may not work. |
1a6506d
to
6ecedbe
Compare
Signed-off-by: İlteriş Yağıztegin Eroğlu <[email protected]>
6ecedbe
to
edd2237
Compare
Looks good to me, hopeful to merge. Just trying to resolve the CI issues causing failing UI tests. |
Thanks for the contribution! :) |
Thank you! |
Mod(ified)hex is Yubico's implementation for somewhat universal OTP entry from a single security key, regardless of keyboard layout (with few exceptions).
This PR implements basic conversion functionality by mapping the characters into hex and converting it back and forth.
Some information is available here: https://en.wikipedia.org/wiki/YubiKey#ModHex