Skip to content

Introduce Yubico's Modhex for Conversion #1105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 16, 2025

Conversation

linuxgemini
Copy link
Contributor

Mod(ified)hex is Yubico's implementation for somewhat universal OTP entry from a single security key, regardless of keyboard layout (with few exceptions).

This PR implements basic conversion functionality by mapping the characters into hex and converting it back and forth.

Some information is available here: https://en.wikipedia.org/wiki/YubiKey#ModHex

@linuxgemini linuxgemini changed the title Introduce Yubico's Modhex Introduce Yubico's Modhex for Conversion Sep 19, 2020
Copy link
Collaborator

@mattnotmitt mattnotmitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything else looks pretty good to me.

@linuxgemini linuxgemini force-pushed the linuxgemini-patch-modhex branch from 3307fb7 to 758ff9b Compare February 13, 2021 12:19
@linuxgemini
Copy link
Contributor Author

Signed-off-by: İlteriş Yağıztegin Eroğlu [email protected]

@linuxgemini
Copy link
Contributor Author

Are there any updates on the merging of this PR?

@a3957273
Copy link
Member

Hey! This pull request has gotten rather old and that's our fault. This project stopped being actively maintained for a while and it looks like your pull request has started to gather dust. Would you be able to update your branch to the latest version of CyberChef and we'll give it a review?

@linuxgemini
Copy link
Contributor Author

Hey! This pull request has gotten rather old and that's our fault. This project stopped being actively maintained for a while and it looks like your pull request has started to gather dust. Would you be able to update your branch to the latest version of CyberChef and we'll give it a review?

Heya! It sure did get dust 😅, I'll try re{bas,factor}ing the code to current CyberChef later today (June 12th). Will poke when its done.

@linuxgemini linuxgemini force-pushed the linuxgemini-patch-modhex branch from 758ff9b to eef51a0 Compare June 12, 2024 11:31
@linuxgemini
Copy link
Contributor Author

@a3957273 I think this should do it, I couldn't get tests working on macOS; so tests may or may not work.

@linuxgemini linuxgemini force-pushed the linuxgemini-patch-modhex branch 2 times, most recently from 1a6506d to 6ecedbe Compare June 17, 2024 23:56
Signed-off-by: İlteriş Yağıztegin Eroğlu <[email protected]>
@linuxgemini linuxgemini force-pushed the linuxgemini-patch-modhex branch from 6ecedbe to edd2237 Compare June 17, 2024 23:59
@linuxgemini
Copy link
Contributor Author

linuxgemini commented Jun 18, 2024

@a3957273 Hi again! Turns out I had some issues in the lib file, the test errors doesn't reflect anything back so it took me a while (perhaps improving test outputs would be a roadmap item?). This one (edd2237) should pass the tests.

Post test edit: Looks like UI tests failed, but the lib passed.

@a3957273
Copy link
Member

Looks good to me, hopeful to merge. Just trying to resolve the CI issues causing failing UI tests.

@a3957273
Copy link
Member

Thanks for the contribution! :)

@a3957273 a3957273 merged commit 1cfbc2b into gchq:master Feb 16, 2025
4 checks passed
@linuxgemini
Copy link
Contributor Author

Thank you!

@linuxgemini linuxgemini deleted the linuxgemini-patch-modhex branch February 16, 2025 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants