-
-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relicense codebase under the MIT license #225
Conversation
cb4d24d
to
4bc8cc3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great to hear that progress has been made on this! The MIT licence sounds like a good choice to me, so RGBDS can be helpful for as many people and projects as possible 😊
src/asm/charmap.c
Outdated
@@ -91,6 +24,8 @@ uint32_t decode(uint32_t *state, uint32_t *codep, uint32_t byte) | |||
#include "asm/main.h" | |||
#include "asm/output.h" | |||
|
|||
uint32_t decode(uint32_t *state, uint32_t *codep, uint32_t byte); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd personally put this in a header file for utf8decoder.h
, just to make it obvious where this function lives, but I'm just splitting hairs here 😛
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. I was just a bit lazy when I created that patch.
This way it is easier to identify the license of the code. Signed-off-by: Antonio Niño Díaz <[email protected]>
With permission from the main authors [1], most of the code has been relicensed under the MIT license. SPDX license identifiers are used so that the license headers in source code files aren't too large. Add CONTRIBUTORS.rst file. [1] #128 Signed-off-by: Antonio Niño Díaz <[email protected]>
The main contributors have agreed to relicense the code under the MIT license: #128
Some other files are still licensed under the ISC and BSD licenses, but they are compatible with the MIT license.
For now, the fact that all the rest of the codebase is consistent is enough.
In order not to have too long headers, I've used SPDX identifiers: https://spdx.org and https://github.com/david-a-wheeler/spdx-tutorial/blob/master/README.md
I've also added a
CONTRIBUTORS.rst
file.@csoren, @JustinLloyd, @vegard, @bentley, @stag019.