all: dump trie journal into file#546
Merged
gballet merged 3 commits intogballet:bloat-per-blockfrom Jun 6, 2025
Merged
Conversation
Signed-off-by: jsvisa <delweng@gmail.com>
Signed-off-by: jsvisa <delweng@gmail.com>
Signed-off-by: jsvisa <delweng@gmail.com>
gballet
approved these changes
Jun 6, 2025
Owner
gballet
left a comment
There was a problem hiding this comment.
I'd prefer to store it as multiple keys into the db, but the batch size problem will probably also affect the full batch. Let's not make this a blocker for the bloatnet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the bloating, the size of trie journal will reached into 4GB++, will exceed pebble's write bactch size(4GB), so after the geth stop, it will panic as below:
Here we try to save the journal into file to bypass this issue.