Fix and polish eth2 API#1
Merged
gballet merged 2 commits intogballet:eth1-eth2-proto1from Jul 24, 2020
Merged
Conversation
gballet
approved these changes
Jul 24, 2020
Owner
gballet
left a comment
gballet
left a comment
There was a problem hiding this comment.
LGTM. Duplicating the whole InsertBlock function will certainly be frowned upon during the final merge. Let's not worry about it until we reach this point, though.
gballet
pushed a commit
that referenced
this pull request
Mar 28, 2025
…ereum#31079) This PR is #1 of a 3-part series that implements the new log index intended to replace core/bloombits. Replaces ethereum#30370 This part implements the new data structure, the log index generator and the search logic. This PR has most of the complexity but it does not affect any existing code yet so maybe it is easier to review separately. FilterMaps data structure explanation: https://gist.github.com/zsfelfoldi/a60795f9da7ae6422f28c7a34e02a07e Log index generator code overview: https://gist.github.com/zsfelfoldi/97105dff0b1a4f5ed557924a24b9b9e7 Search pattern matcher code overview: https://gist.github.com/zsfelfoldi/5981735641c956afb18065e84f8aff34 Note that the possibility of a tree hashing scheme and remote proof protocol are mentioned in the documents above but they are not exactly specified yet. These specs are WIP and will be finalized after the local log indexer/filter code is finalized and merged. --------- Co-authored-by: Felix Lange <fjl@twurst.com>
gballet
pushed a commit
that referenced
this pull request
Sep 11, 2025
…ereum#31079) This PR is #1 of a 3-part series that implements the new log index intended to replace core/bloombits. Replaces ethereum#30370 This part implements the new data structure, the log index generator and the search logic. This PR has most of the complexity but it does not affect any existing code yet so maybe it is easier to review separately. FilterMaps data structure explanation: https://gist.github.com/zsfelfoldi/a60795f9da7ae6422f28c7a34e02a07e Log index generator code overview: https://gist.github.com/zsfelfoldi/97105dff0b1a4f5ed557924a24b9b9e7 Search pattern matcher code overview: https://gist.github.com/zsfelfoldi/5981735641c956afb18065e84f8aff34 Note that the possibility of a tree hashing scheme and remote proof protocol are mentioned in the documents above but they are not exactly specified yet. These specs are WIP and will be finalized after the local log indexer/filter code is finalized and merged. --------- Co-authored-by: Felix Lange <fjl@twurst.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was done?
eth2_produceBlocktimestampas its parent, otherwise produced block fails on importlog.Info("Produce block", "parentHash", parentHash)eth2_insertBlockInsertChainwithInsertChainWithoutSealVerificationineth2_insertBlocketh2_setHeadapi.eth.BlockChain().GetBlockByHash(api.head)withapi.eth.BlockChain().CurrentBlock()