Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure Repository #66

Merged
merged 8 commits into from
Jan 17, 2024
Merged

Restructure Repository #66

merged 8 commits into from
Jan 17, 2024

Conversation

dostuffthatmatters
Copy link
Contributor

@dostuffthatmatters dostuffthatmatters commented Jan 17, 2024

This closes #64.

  • Use tests/ and jsonref directories instead of having all files in root
  • Add black and flake8 as dev dependencies (next to pytest)
  • In pyproject.toml use [project.optional-dependencies] notation instead of [tool.pdm.dev-dependencies] because then one can simply use pip install ".[dev]" to install optional dependencies
  • Fix package build and GitHub actions

This is transparent to users. All import paths are the same.

Move proxytypes in subdirectory
Update `pyproject.toml` and add `pdm.lock`
Move tests into `test/` directory and split them into multiple files
Fix flake8 errors
Add `black` to dev dependencies and fix CI
Correctly configure package build
@gazpachoking
Copy link
Owner

Looks good to me, thanks. Seems like some of the tests got moved out of the main file, but I don't see those tests removed from the main file?

Remove duplicate tests
@dostuffthatmatters
Copy link
Contributor Author

dostuffthatmatters commented Jan 17, 2024

Seems like some of the tests got moved out of the main file, but I don't see those tests removed from the main file?

I split the test classes in tests.py into five separate files (one file per test class):

Screenshot 2024-01-17 at 23 17 06

I can revert it, of course. Just found that to look cleaner.

EDIT: In the commit 1eba891, I removed some tests I forgot to delete. Before and after the change there are 107 pytests, so all should be there.

@gazpachoking
Copy link
Owner

EDIT: In the commit 1eba891, I removed some tests I forgot to delete. Before and after the change there are 107 pytests, so all should be there.

Yep, that's what I meant, looks good now.

jsonref/__init__.py Outdated Show resolved Hide resolved
Make it possible to `from jsonref import LazyProxy` again
Specify `# noqa` comment more
@gazpachoking gazpachoking merged commit f21e8af into gazpachoking:master Jan 17, 2024
6 checks passed
@gazpachoking
Copy link
Owner

Awesome. Thanks so much!

@dostuffthatmatters
Copy link
Contributor Author

dostuffthatmatters commented Jan 17, 2024

Awesome. Thanks so much!

Sure :) Would not like to have a package conflict somewhere down the road when two packages want to install the same filenames. Thank you for merging it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use jsonref/ and directory for the source code
2 participants