Fix <ignition_frame_id> not working for GpuLidarSensor#218
Conversation
Signed-off-by: Guillaume Doisy <guillaume.doisy@wyca.fr>
Signed-off-by: Guillaume Doisy <guillaume.doisy@wyca.fr>
| msgs::Convert(_now); | ||
| // Set frame_id | ||
| for (auto i = 0; i < this->dataPtr->pointMsg.mutable_header()->data_size(); ++i) { | ||
| if (this->dataPtr->pointMsg.mutable_header()->data(i).key() == "frame_id" |
There was a problem hiding this comment.
Style nits.
The linter is complaining here:
/github/workspace/src/GpuLidarSensor.cc:260: Lines should be <= 80 characters long [whitespace/line_length] [2]
/github/workspace/src/GpuLidarSensor.cc:264: Lines should be <= 80 characters long [whitespace/line_length] [2]
Also, please put the { in a new line
There was a problem hiding this comment.
lint is now happy but not so sure about the formating
doisyg
force-pushed
the
Fix_GpuLidarSensor_frame
branch
from
6bf97e8 to
ad8c09d
Compare
Codecov Report
@@ Coverage Diff @@
## ign-sensors6 #218 +/- ##
================================================
+ Coverage 72.55% 80.00% +7.44%
================================================
Files 33 1 -32
Lines 3094 15 -3079
================================================
- Hits 2245 12 -2233
+ Misses 849 3 -846 Continue to review full report at Codecov.
|
|
changes look good to me. Not sure why some rendering tests on Jammy CI is failing but they do not look related. |
6 participants
🦟 Bug fix
Fixes #217
Additionally it seems that frame_id was not also applied for ForceTorqueSensor and SegmentationCameraSensor, so fixed too.
Summary
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.