Make alpha optional when parsing a Color from an input stream #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@osrf-jenkins run tests |
|
update changelog? changes look good to me |
iche033
approved these changes
Apr 27, 2020
nkoenig
approved these changes
Apr 28, 2020
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Steven Peters <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The stream insertion operator is used in libsdformat to parse Color values, and as far as I know, alpha is already optional, but currently, if the exception mask for
failbitis set (we are doing that in libsdformat to catch more parsing errors), theoperator>>function will throw an exception. This PR keeps the current behavior by keeping alpha optional, but prevents an exception from being thrown.