Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msgs.cc: add missing <array> include #3290

Merged
merged 1 commit into from
Jan 26, 2023
Merged

Conversation

scpeters
Copy link
Member

🦟 Bug fix

Fixes osrf/homebrew-simulation#2179

Summary

There is a reported build failure on some versions of macOS in osrf/homebrew-simulation#2179, and I observed a failed bottle build on macOS Monterey:

Build Status https://build.osrfoundation.org/job/generic-release-homebrew_triggered_bottle_builder/1088/label=osx_monterey/

There is a complaint about msgs.cc:

gazebo/msgs/msgs.cc:2023:34: error: implicit instantiation of undefined template 'std::array<std::string, 2>'
std::array<std::string, 2> dimensions = {{"horizontal", "vertical"}};
^

The solution is to include the <array> header file.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Fixes homebrew build.

Signed-off-by: Steve Peters <[email protected]>
@traversaro
Copy link
Collaborator

Please ignore conda-forge CI failures, they are not related to the PR and will be solved by #3287 .

@scpeters
Copy link
Member Author

I'm not sure why the abi-checker jobs are failing too; I'll look into that. I'll merge this anyway since it doesn't affect API/ABI

@scpeters scpeters merged commit 728840d into gazebo11 Jan 26, 2023
@scpeters scpeters deleted the scpeters/add_missing_include branch January 26, 2023 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gazebo 11 fails to install
2 participants