Skip to content

brew: set cmake args for keg-only qwt-qt5#535

Merged
scpeters merged 6 commits intomasterfrom
scpeters/brew-qwt-qt5
Oct 12, 2021
Merged

brew: set cmake args for keg-only qwt-qt5#535
scpeters merged 6 commits intomasterfrom
scpeters/brew-qwt-qt5

Conversation

@scpeters
Copy link
Contributor

@scpeters scpeters commented Oct 12, 2021

As of Homebrew/homebrew-core#87092, qwt-qt5 is a keg-only formula, so we need to set environment variables so gazebo CI can find it.

@scpeters
brew: set env variables for keg-only qwt-qt5
4b8d185 
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters scpeters requested a review from j-rivero as a code owner October 12, 2021 04:22
@scpeters
Copy link
Contributor Author

scpeters commented Oct 12, 2021

example failure: Build Status https://build.osrfoundation.org/job/gazebo-ci-pr_any-homebrew-amd64/2566/

-- BUILD ERRORS: These must be resolved before compiling.
-- 	Missing: libqwt-dev. Required for plotting.
-- END BUILD ERRORS

testing with this branch: Build Status https://build.osrfoundation.org/job/gazebo-ci-gazebo11-homebrew-amd64/96/

@scpeters
Set QWT_WIN_* cmake variables instead of env
a979195 
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters
add missing /
04da9f0 
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters
remove ""
5b6d861 
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters
Copy link
Contributor Author

scpeters commented Oct 12, 2021

this is not working for some reason

@scpeters
fix lib
f107810 
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters scpeters changed the title brew: set env variables for keg-only qwt-qt5 brew: set cmake args for keg-only qwt-qt5 Oct 12, 2021
@scpeters
Copy link
Contributor Author

scpeters commented Oct 12, 2021

it's finally working

Build Status https://build.osrfoundation.org/job/gazebo-ci-gazebo11-homebrew-amd64/100/

@scpeters
fix comment
e14994e 
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters
Copy link
Contributor Author

scpeters commented Oct 12, 2021

merging now to unbreak gazebo CI

@scpeters scpeters merged commit 56a2eb9 into master Oct 12, 2021
@scpeters scpeters deleted the scpeters/brew-qwt-qt5 branch October 12, 2021 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@j-rivero j-rivero j-rivero approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@scpeters @j-rivero