Use tinyxml2 for sdformat10 #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Carroll <[email protected]>
|
Used for gazebosim/sdformat#264 |
chapulina
approved these changes
Jun 12, 2020
|
We also need:
|
scpeters
reviewed
Jun 12, 2020
| # SDFORMAT 10 and above use tinyxml2 | ||
| if [[ ${SDFORMAT_MAJOR_VERSION} -ge 10]]; then | ||
| SDFORMAT_NO_IGN_DEPENDENCIES="${SDFORMAT_NO_IGN_DEPENDENCIES} \\ | ||
| libtinyxml2-dev" |
There was a problem hiding this comment.
this is what it should look like eventually, but until everything is merged, I think it will keep other branches targeting sdf10 working if we install both libtinyxml-dev and libtinyxml2-dev for 10+. Once gazebosim/sdformat#264 is merged, the libtinyxml-dev line can be removed.
how does that sound?
There was a problem hiding this comment.
Completely reasonable, updated.
Signed-off-by: Michael Carroll <[email protected]>
scpeters
approved these changes
Jun 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michael Carroll [email protected]