Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: service worker is not always alive #119

Merged
merged 3 commits into from
Apr 30, 2023
Merged

fix: service worker is not always alive #119

merged 3 commits into from
Apr 30, 2023

Conversation

CW-B-W
Copy link
Contributor

@CW-B-W CW-B-W commented Apr 18, 2023 •
edited

Issue

As @gautamkrishnar mentioned in #118 (comment)

For manifest v3 extensions, the service worker won't always stay alive so the extension need to be converted to more of an event-driven approach

Description

This PR aims to resolve this issue with the Offscreen API.
The solution referenced from Persistent Service Worker in Chrome Extension.

Result

The service worker is still alive after the extension was turned on for hours, and can still send tasks to Motrix succesfully.

@gautamkrishnar
Copy link
Owner

@CW-B-W Great implementation. thanks for working on this.

@gautamkrishnar gautamkrishnar merged commit 1f6ae7d into gautamkrishnar:master Apr 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@CW-B-W @gautamkrishnar