-
Notifications
You must be signed in to change notification settings - Fork 41
WordPress source plugins #23
base: master
Are you sure you want to change the base?
WordPress source plugins #23
Conversation
TBD? | ||
|
||
- **[Detailed design](#detailed-design)** | ||
- **Would this mean moving the existing plugins supported out of `gatsby-source-wordpress`?** Right now I think we should keep ACF support in `gatsby-source-wordpress`, but I can also see the case for moving all WordPress plugin…plugins out of it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can actually move this out of main package, but still ship them by default (at least initially). This would also allow us to validate that our extension points actually do make sense if we would implement ACF (and other things we support) in separate packages that use public wordpress plugin extension points
I think this is very good write up of the issue and we should start thinking about "Detailed design". I will now look into plugin implementation to see what extension points would be needed to be able to move |
Thanks! Just to save the reference, here’s the changes I made to add Gravity Forms support to Gatsby v1.x WordPress plugin that you already reviewed gatsbyjs/gatsby#5599 Not sure if that’s still a relevant example now, but I can port it as a test later on. |
For the sake of getting feedback this, and keeping gatsbyjs/gatsby#5796 active, I’ve updated this RFC for adding subplugins to
gatsby-source-wordpress
.Read the the full draft here…
Thanks!