Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the gatsby-plugin-sass work with 1.0 #884

Merged
merged 2 commits into from
May 1, 2017
Merged

Conversation

smh
Copy link
Contributor

@smh smh commented May 1, 2017

  • Need an index.js file so node can find the plugin
  • Make it compatible with 1.0 (no args indirection in parameter)

@gatsbybot
Copy link
Collaborator

Deploy preview ready!

Built with commit aaa9784

https://deploy-preview-884--gatsbyjs.netlify.com

@gatsbybot
Copy link
Collaborator

Deploy preview ready!

Built with commit aaa9784

https://deploy-preview-884--gatsbygram.netlify.com

@KyleAMathews
Copy link
Contributor

Oh thanks! We need to get an example site setup for this and other style plugins, e.g. Glamor and others as they're created to make sure they work :-) Example sites are our integration tests.

If you feel up to that, a very simple site with one page and only this plugin would be 💯 I think the naming convention will be just using-* with * being the plugin/tech so in this case using-sass.

@KyleAMathews KyleAMathews merged commit 23b3fe4 into gatsbyjs:1.0 May 1, 2017
@smh
Copy link
Contributor Author

smh commented May 1, 2017

sure, I'll see if I can get that done

@gatsbybot
Copy link
Collaborator

gatsbybot commented May 1, 2017 via email

@jlengstorf
Copy link
Contributor

Hiya @smh! 👋

This is definitely late, but on behalf of the entire Gatsby community, I wanted to say thank you for being here.

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (We’ve got t-shirts and hats, plus some socks that are really razzing our berries right now.)
  2. If you’re not already part of it, we just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. You’ll receive an email shortly asking you to confirm. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If you have questions, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again! 💪💜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants